feat: add single Codeflare entrypoint with handler pattern and remove legacy auth#1091
feat: add single Codeflare entrypoint with handler pattern and remove legacy auth#1091szaher wants to merge 11 commits into
Conversation
Introduces the design for a unified SDK entrypoint with SDKConfig, ClusterHandler, and JobHandler using kube-authkit for authentication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ean set_api_client, update E2E/notebooks - Remove print and verification call from set_api_client (now internal-only) - Make namespace fallback consistent: all handler methods fall back to "default" - Fix E2E tests: replace TokenAuthentication with Codeflare/SDKConfig - Fix demo notebooks: use Codeflare(config=SDKConfig(auth=...)) instead of set_api_client - Fix unused import (patch) and non-deterministic set ordering in error msg - Add tests for namespace fallback in create() and submit() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
+ Coverage 96.61% 96.68% +0.07%
==========================================
Files 23 24 +1
Lines 2306 2296 -10
==========================================
- Hits 2228 2220 -8
+ Misses 78 76 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
Summary
Codeflareclass as the single SDK entrypoint — authentication,namespace, retries, timeout, and logging configured once via
SDKConfigcf.clusters.*andcf.jobs.*handler pattern (thin orchestratorsthat delegate to existing
Cluster/RayJobclasses)TokenAuthentication,KubeConfigFileAuthentication,Authentication,KubeConfiguration) — kube-authkit is now the only auth methodUsage